update_lib test format fix + deps for atexit & eintr by ShaharNaveh · Pull Request #7227 · RustPython/RustPython

ShaharNaveh · 2026-02-25T10:09:19Z

New output:

Standalone Tests

Untracked Files

site-packages/README.txt

Original Files

PSF-LICENSE
README.md
_dummy_os.py
_dummy_thread.py
_pycodecs.py
dummy_threading.py

Summary by CodeRabbit

Chores
- Updated internal test discovery logic to broaden test module identification.
- Enhanced test list formatting with improved visual markers.
- Added dependency mappings for additional test modules.

coderabbitai · 2026-02-25T10:14:38Z

📝 Walkthrough

Walkthrough

The pull request modifies test discovery logic and formatting in cmd_todo.py to wrap test names in backticks and adjusts which test modules are discovered. Additionally, it expands the DEPENDENCIES mapping in deps.py with entries for "atexit" and "eintr" modules, each with corresponding test file dependencies.

Changes

Cohort / File(s)	Summary
Test Discovery & Formatting `scripts/update_lib/cmd_todo.py`	Modified `get_all_tests` to only exclude entries not starting with `_test` or `test_`; updated `format_test_todo_list` and `format_todo_list` to wrap test names in backticks for improved readability.
Dependency Mapping Expansion `scripts/update_lib/deps.py`	Added two new entries to DEPENDENCIES mapping: "atexit" and "eintr", each with test dependencies ("test_atexit.py", "_test_atexit.py") and ("test_eintr.py", "_test_eintr.py") respectively.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

update_lib todo also shows test todo #6859: Modifies the same test-discovery and formatting helpers (get_all_tests, format_test_todo_list, format_todo_list) to change how tests are discovered and rendered.
[update_lib] show dependent tests in deps subcommand #6828: Directly adds the same "atexit" and "eintr" entries to the DEPENDENCIES mapping in deps.py.
[update_lib] Apply test grouping to deps #6867: Extensively expands and refactors the DEPENDENCIES structure and related APIs in scripts/update_lib/deps.py.

Suggested reviewers

moreal

Poem

🐰 Our tests now hop in backticks bright,
Atexit and eintr join the fight,
Discovery logic bounds with glee,
Dependencies mapped, oh what we see! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: test formatting fixes for the update_lib script and addition of dependencies for atexit and eintr modules.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

scripts/update_lib/deps.py (1)

663-668: Missing trailing comma in eintr test list (inconsistent with rest of file).

Every other multi-element list in DEPENDENCIES uses a trailing comma; eintr's list does not.

🔧 Proposed fix

     "eintr": {
         "test": [
             "test_eintr.py",
-            "_test_eintr.py",
-        ]
+            "_test_eintr.py",
+        ],
     },
 },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/update_lib/deps.py` around lines 663 - 668, The DEPENDENCIES mapping
contains the "eintr" entry whose "test" list lacks a trailing comma; update the
"eintr" test list (the "test" value under the "eintr" key in DEPENDENCIES) to
include a trailing comma after the last element so it matches the style used
across other multi-element lists in the file.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@scripts/update_lib/deps.py`:
- Around line 663-668: The DEPENDENCIES mapping contains the "eintr" entry whose
"test" list lacks a trailing comma; update the "eintr" test list (the "test"
value under the "eintr" key in DEPENDENCIES) to include a trailing comma after
the last element so it matches the style used across other multi-element lists
in the file.

ℹ️ Review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f250a0 and f866de6.

📒 Files selected for processing (2)

scripts/update_lib/cmd_todo.py
scripts/update_lib/deps.py

* update_lib deps for atexit & eintr * Fix test format

$@ShaharNaveh$ ShaharNaveh changed the title ~~update_lib deps for atexit~~ update_lib test format fix + deps for atexit & eintr Feb 25, 2026

$@ShaharNaveh$ ShaharNaveh added the skip:ci Skip running the ci label Feb 25, 2026

ShaharNaveh added 2 commits February 25, 2026 11:45

$@ShaharNaveh$

update_lib deps for atexit & eintr

4561dbb

$@ShaharNaveh$

Fix test format

f866de6

$@ShaharNaveh$

ShaharNaveh force-pushed the deps-atexit-tests branch from ffb8c85 to f866de6 Compare February 25, 2026 10:46

$@youknowone$

youknowone marked this pull request as ready for review February 25, 2026 12:19

$youknowone$

youknowone approved these changes Feb 25, 2026

View reviewed changes

$coderabbitai[bot]$

coderabbitai Bot reviewed Feb 25, 2026

View reviewed changes

$@youknowone$

youknowone merged commit 457d328 into RustPython:main Feb 26, 2026
9 checks passed

youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026

$@ShaharNaveh$

update_lib test format fix + deps for atexit & eintr (RustPython#7227)

3b394f1

* update_lib deps for atexit & eintr * Fix test format

Navigation Menu

Uh oh!

update_lib test format fix + deps for atexit & eintr - #7227

update_lib test format fix + deps for atexit & eintr#7227
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:deps-atexit-tests

$@ShaharNaveh$ ShaharNaveh commented Feb 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Feb 25, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

$@coderabbitai$ coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ShaharNaveh commented Feb 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Standalone Tests

Untracked Files

Original Files

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

$@ShaharNaveh$ ShaharNaveh commented Feb 25, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 25, 2026 •

edited

Loading

$@coderabbitai$ coderabbitai Bot left a comment