Skip to content

Update ruff to 0.14.11 in the CI - #6708

Merged
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:CI-update-ruff
Jan 12, 2026
Merged

Update ruff to 0.14.11 in the CI#6708
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:CI-update-ruff

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jan 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

ref: #6707 (comment)

Summary by CodeRabbit

  • Chores

    • Updated code quality tool version in CI workflows.

  • Style

    • Reorganized imports in test utilities script.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions

github-actions Bot commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

Code has been automatically formatted

The code in this PR has been formatted using cargo fmt --all.
Please pull the latest changes before pushing again:

git pull origin CI-update-ruff

@coderabbitai

coderabbitai Bot commented Jan 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
πŸ“ Walkthrough

Walkthrough

Updates ruff-action version from 0.14.9 to 0.14.11 in two CI workflow files and reorders imports in a Python script. All changes are minor version/configuration updates with no functional behavioral modifications.

Changes

Cohort / File(s) Summary
CI Workflow Version Bumps
.github/workflows/ci.yaml, .github/workflows/pr-auto-commit.yaml		 Bumps astral-sh/ruff-action dependency from version 0.14.9 to 0.14.11 in both workflow files. No changes to workflow structure or execution logic.
Script Import Reordering
scripts/fix_test.py		 Reorders imports from lib_updater: changes order from apply_patches, PatchSpec, UtMethod to PatchSpec, UtMethod, apply_patches. No runtime impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A rabbit hops with glee,
Ruff bumped to .14.11, naturally,
Imports shuffle-sorted with care,
Tiny tweaks float through the air! ✨

πŸš₯ Pre-merge checks | βœ… 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
βœ… Passed checks (2 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The pull request title accurately describes the main change: updating ruff-action from 0.14.9 to 0.14.11 in CI workflow files. It is concise, clear, and directly reflects the primary modification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • πŸ“ Generate docstrings
πŸ“œ Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 29bb8b4 and 32edf7b.

πŸ“’ Files selected for processing (3)
  • .github/workflows/ci.yaml
  • .github/workflows/pr-auto-commit.yaml
  • scripts/fix_test.py
🧰 Additional context used
πŸ““ Path-based instructions (2)
**/*.py

πŸ“„ CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.py: In most cases, Python code should not be edited; bug fixes should be made through Rust code modifications only
Follow PEP 8 style for custom Python code
Use ruff for linting Python code

Files:

  • scripts/fix_test.py
**/*test*.py

πŸ“„ CodeRabbit inference engine (.github/copilot-instructions.md)

**/*test*.py: NEVER comment out or delete any test code lines except for removing @unittest.expectedFailure decorators and upper TODO comments
NEVER modify test assertions, test logic, or test data in test files
When a test cannot pass due to missing language features, keep it as expectedFailure and document the reason; do not comment it out
The only acceptable modifications to test files are: (1) Removing @unittest.expectedFailure decorators and the upper TODO comments when tests actually pass, and (2) Adding @unittest.expectedFailure decorators when tests cannot be fixed

Files:

  • scripts/fix_test.py
🧠 Learnings (2)
πŸ“š Learning: 2025-12-27T14:03:49.034Z 
Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-27T14:03:49.034Z
Learning: Applies to **/*.py : Use ruff for linting Python code

Applied to files:

  • .github/workflows/pr-auto-commit.yaml
  • .github/workflows/ci.yaml
πŸ“š Learning: 2025-08-30T14:40:05.858Z 
Learnt from: ShaharNaveh
Repo: RustPython/RustPython PR: 6089
File: scripts/lib_updater.py:292-297
Timestamp: 2025-08-30T14:40:05.858Z
Learning: In scripts/lib_updater.py, the --inplace flag intentionally writes to orig_file (not remote_file) even though patches are applied to remote_file content. This workflow allows updating the original RustPython test file with patches applied to new upstream CPython content.

Applied to files:

  • scripts/fix_test.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (windows-2025)
  • GitHub Check: Run rust tests (windows-2025)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Check Rust code with clippy
  • GitHub Check: Check the WASM package and demo
πŸ”‡ Additional comments (3)
scripts/fix_test.py (1)

30-30: LGTM! Import ordering follows ruff conventions.

The alphabetical reordering of imports is consistent with ruff's isort rule and represents no functional change.

.github/workflows/pr-auto-commit.yaml (1)

45-45: LGTM! Consistent ruff version upgrade.

The ruff version update to 0.14.11 is consistent with the change in ci.yaml, ensuring uniform linting across CI workflows.

.github/workflows/ci.yaml (1)

450-450: The ruff version upgrade to 0.14.11 is validβ€”it's the latest stable version released on January 8, 2026. No further action needed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
youknowone merged commit 00bfea8 into RustPython:main Jan 12, 2026
23 of 24 checks passed
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
@ShaharNaveh @github-actions @terryluan12
Update ruff to 0.14.11 in the CI (RustPython#6708)
ffa534e 
* Update ruff to 0.14.11 in the CI

* Auto-format: cargo fmt --all

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@coderabbitai coderabbitai Bot mentioned this pull request Feb 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone