Remove user defined docstrings for builtins.str - #6232
Conversation
WalkthroughDocumentation comments were removed from six PyStr methods (removeprefix, removesuffix, format_map, title, isprintable, istitle) in the builtins module without modifying their implementations or behavior. Changes
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~3 minutes
Poem
Pre-merge checks and finishing touchesβ Failed checks (1 warning)
β Passed checks (2 passed)
β¨ Finishing touches
π§ͺ Generate unit tests (beta)
π Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro π Files selected for processing (1)
π€ Files with no reviewable changes (1)
β° Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ShaharNaveh I forgot what was the major reason to split it out. Probably the license and workflow part. To integrate it again, guidelines:
|
I intend to refractor it, either way I'll make it will work.
Sure, will copy CPython license to
I thought of having the generate script to have a |
The current script is depends on python runtime. Each platform generate their own set of document. To cover the entire platform, the results from different platforms must be merged. |
Make sense, I don't expect |
|
Yes, they are. |
@youknowone would you object to move https://github.com/RustPython/__doc__.git to this project? (in it's own crate)
Summary by CodeRabbit